[PATCH 1 of 3] pycompat: correct the shlex.split() proxy method signature in py3

Matt Harbison mharbison72 at gmail.com
Wed Feb 21 00:56:12 EST 2018


> On Feb 20, 2018, at 11:32 PM, Matt Harbison <mharbison72 at gmail.com> wrote:
> 
> # HG changeset patch
> # User Matt Harbison <matt_harbison at yahoo.com>
> # Date 1519180650 18000
> #      Tue Feb 20 21:37:30 2018 -0500
> # Node ID 50a2885e94783ecce0820a08dd40d26cadbf0ae1
> # Parent  aefb75730ea34f545f0756bf8441fc9ae07bf8dc
> pycompat: correct the shlex.split() proxy method signature in py3
> 
> diff --git a/mercurial/pycompat.py b/mercurial/pycompat.py
> --- a/mercurial/pycompat.py
> +++ b/mercurial/pycompat.py
> @@ -261,7 +261,7 @@
>         return dic
> 
>     # TODO: handle shlex.shlex().
> -    def shlexsplit(s):
> +    def shlexsplit(s, comments=False, posix=True):
>         """
>         Takes bytes argument, convert it to str i.e. unicodes, pass that into
>         shlex.split(), convert the returned value to bytes and return that for

Oops.  I forgot to forward the arguments to the actual call...



More information about the Mercurial-devel mailing list