D2366: narrowwirepeer: add some strkwargs to fix a crash on py3

pulkit (Pulkit Goyal) phabricator at mercurial-scm.org
Wed Feb 21 12:54:23 EST 2018


pulkit added inline comments.

INLINE COMMENTS

> narrowwirepeer.py:51
>                  kwargs["excludepats"] = ','.join(exclude)
> -            return orig(cmd, *args, **kwargs)
> +            return orig(cmd, *args, **pycompat.strkwargs(kwargs))
>          extensions.wrapfunction(peer, '_calltwowaystream', wrapped)

I think better would be to add r'' prefixes as in above two lines as that will save a call to strkwargs.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D2366

To: durin42, #hg-reviewers
Cc: pulkit, mercurial-devel


More information about the Mercurial-devel mailing list