D2367: narrowcommands: add some missing strkwargs calls for py3

pulkit (Pulkit Goyal) phabricator at mercurial-scm.org
Wed Feb 21 12:56:10 EST 2018


pulkit added inline comments.

INLINE COMMENTS

> narrowcommands.py:146
>              opts['exclude'] = excludes
> +        opts = pycompat.strkwargs(opts)
>      return orig(ui, repo, *args, **opts)

What about adding r'' prefixes to prevent the the function calls which iterate over all the keys and encode/decode them?

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D2367

To: durin42, #hg-reviewers
Cc: pulkit, mercurial-devel


More information about the Mercurial-devel mailing list