D2297: py3: backout 7c54917b31f6 to make sure second argument of open() is str

pulkit (Pulkit Goyal) phabricator at mercurial-scm.org
Thu Feb 22 10:06:18 EST 2018


pulkit added a comment.


  In https://phab.mercurial-scm.org/D2297#37960, @yuja wrote:
  
  > Can you elaborate why you think it wasn't a good idea to replace open()?
  >
  > IMHO, it's as hackish as replacing '' with b''.
  
  
  Added couple of points.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D2297

To: pulkit, #hg-reviewers
Cc: yuja, mercurial-devel


More information about the Mercurial-devel mailing list