D2453: py3: use email.utils module instead of email.Utils

yuja (Yuya Nishihara) phabricator at mercurial-scm.org
Mon Feb 26 08:16:09 EST 2018


yuja requested changes to this revision.
yuja added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> patchbomb.py:748
>  
> -    sender_addr = emailmod.Utils.parseaddr(sender)[1]
> +    sender_addr = eutil.parseaddr(pycompat.sysstr(sender))[1]
>      sender = mail.addressencode(ui, sender, _charsets, opts.get('test'))

Perhaps it should be `encoding.strfromlocal()` because `sender`
is provided from user config or argument.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D2453

To: pulkit, #hg-reviewers, yuja
Cc: yuja, mercurial-devel


More information about the Mercurial-devel mailing list