D2455: py3: use '%d' for integers instead of '%s'

yuja (Yuya Nishihara) phabricator at mercurial-scm.org
Mon Feb 26 08:20:48 EST 2018


yuja requested changes to this revision.
yuja added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> patchbomb.py:673
> +        return '<%s.%d@%s>' % (id[:20], int(start_time[0]),
> +                pycompat.sysbytes(socket.getfqdn()))
>  

No idea what encoding is expected, but it could be `encoding.strtolocal()` assuming it was that in Python2.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D2455

To: pulkit, #hg-reviewers, yuja
Cc: yuja, mercurial-devel


More information about the Mercurial-devel mailing list