D2457: py3: slice over bytes to prevent getting ascii values

yuja (Yuya Nishihara) phabricator at mercurial-scm.org
Mon Feb 26 08:22:13 EST 2018


yuja requested changes to this revision.
yuja added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> patch.py:2521
>                              for token in tabsplitter.findall(stripline):
> -                                if '\t' == token[0]:
> +                                if '\t' == token[0:1]:
>                                      yield (token, 'diff.tab')

Nit: could be `token.startswith('\t')`

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D2457

To: pulkit, #hg-reviewers, yuja
Cc: yuja, mercurial-devel


More information about the Mercurial-devel mailing list