D2472: pycompat: prevent encoding or decoding values if not required

[yuja (Yuya Nishihara)]

yuja requested changes to this revision.
yuja added a comment.
This revision now requires changes to proceed.


  I'm 0 for this move.
  
  I'm not a fan of making function inputs and outputs obscure because we'll
  be likely to have a hard time to fix it in future. Mixing bytes and unicodes is
  horrible. But if it's painful to be strict on url type, I'll say go for it.

INLINE COMMENTS

> pycompat.py:197
> +            return url.decode(u'ascii')
>  
>      def bytesurl(url):

Need to return an unmodified value.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D2472

To: pulkit, #hg-reviewers, yuja
Cc: yuja, mercurial-devel