D1809: tests: switch test from '--config ui.editor=~/foo' to HGEDITOR=~/foo
spectral (Kyle Lippincott)
phabricator at mercurial-scm.org
Fri Jan 5 00:29:39 UTC 2018
spectral created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
The test is currently not testing anything, the '--config ui.editor=~/path'
argument is apparently of lower priority than the HGEDITOR that run-tests.py is
setting.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D1809
AFFECTED FILES
tests/test-install.t
CHANGE DETAILS
diff --git a/tests/test-install.t b/tests/test-install.t
--- a/tests/test-install.t
+++ b/tests/test-install.t
@@ -98,7 +98,7 @@
#if execbit
$ chmod 755 tools/testeditor.exe
#endif
- $ hg debuginstall --config ui.editor=~/tools/testeditor.exe
+ $ HGEDITOR="~/tools/testeditor.exe" hg debuginstall
checking encoding (ascii)...
checking Python executable (*) (glob)
checking Python version (*) (glob)
@@ -116,7 +116,7 @@
checking "re2" regexp engine \((available|missing)\) (re)
checking templates (*mercurial?templates)... (glob)
checking default template (*mercurial?templates?map-cmdline.default) (glob)
- checking commit editor... (* -c "import sys; sys.exit(0)") (glob)
+ checking commit editor... ($TESTTMP/tools/testeditor.exe)
checking username (test)
no problems detected
To: spectral, #hg-reviewers
Cc: mercurial-devel
More information about the Mercurial-devel
mailing list