D1729: githelp: don't reference 3rd party commands for `git show`

krbullock (Kevin Bullock) phabricator at mercurial-scm.org
Fri Jan 5 03:10:04 UTC 2018


krbullock requested changes to this revision.
krbullock added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> githelp.py:883
> +            cmd = Command('status')
>              cmd['--change'] = 'tip'
>          else:

I don't think `tip` is correct here, shouldn't this be `.`?

> githelp.py:887
>              cmd.append('--style status')
>              cmd.append('-r tip')
>      elif len(args) > 0:

Same here, shouldn't use `tip` in newly-added docs or help if we can avoid it.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D1729

To: indygreg, #hg-reviewers, durin42, pulkit, krbullock
Cc: krbullock, pulkit, mercurial-devel


More information about the Mercurial-devel mailing list