D1808: debugcommands: print out the editor that was searched for (post shlexsplit)

[krbullock (Kevin Bullock)]

krbullock requested changes to this revision.
krbullock added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> debugcommands.py:1212
>      fm.write('editor', _("checking commit editor... (%s)\n"), editor)
> -    cmdpath = util.findexe(pycompat.shlexsplit(editor)[0])
> +    editorbin = pycompat.shlexsplit(editor)[0]
> +    cmdpath = util.findexe(editorbin)

In this patch, we end up printing something potentially different in the "checking" line than in the "can't find editor" line. That seems wrong. I think I'd rather we do the shlexsplit before writing the "checking commit editor..." message and print the fully-interpreted path there.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D1808

To: spectral, #hg-reviewers, krbullock
Cc: krbullock, mercurial-devel