D1767: cext: make nullentry a member of index types
yuja (Yuya Nishihara)
phabricator at mercurial-scm.org
Fri Jan 5 03:53:44 UTC 2018
yuja requested changes to this revision.
yuja added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> revlog.c:1876
>
> + /* Initialize before argument-checking to avoid index_dealloc() crash. */
> + self->nullentry = Py_BuildValue("iiiiiiis#", 0, 0, 0,
This comment shouldn't be moved. We need to NULLify all attributes, but don't
have to create PyObject.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D1767
To: indygreg, #hg-reviewers, yuja
Cc: yuja, mercurial-devel
More information about the Mercurial-devel
mailing list