D1768: cext: obtain reference to index entry type

yuja (Yuya Nishihara) phabricator at mercurial-scm.org
Fri Jan 5 04:54:32 UTC 2018


yuja requested changes to this revision.
yuja added a comment.
This revision now requires changes to proceed.


  > We hold off incrementing the version of the "parsers" extension
  >  because nothing in core relies on the new API yet.
  
  It's really minor nit, but we have to increment the version since new
  compiled module doesn't work with old `pure.parsers` module, which
  provides no IndexV1Entry type.

INLINE COMMENTS

> revlog.c:2117
> +
> +	PyModule_AddObject(mod, "IndexV1Entry", index_entry_type);
>  }

Can we be sure that this `IndexV1Entry` is identical to `self->entrytype`
after reloading Python modules?

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D1768

To: indygreg, #hg-reviewers, yuja
Cc: yuja, mercurial-devel


More information about the Mercurial-devel mailing list