[PATCH] hgweb: make different kinds of commits look differently on /graph (RFC)

Yuya Nishihara yuya at tcha.org
Fri Jan 5 06:47:23 UTC 2018


On Tue, 19 Dec 2017 21:52:15 +0800, Anton Shestakov wrote:
> # HG changeset patch
> # User Anton Shestakov <av6 at dwimlabs.net>
> # Date 1513687285 -28800
> #      Tue Dec 19 20:41:25 2017 +0800
> # Node ID c7259f4340b50c8b1863ac9a1379ab8412b27b87
> # Parent  e28dedf4ff4368820bbb085c668c3e6ea2088842
> hgweb: make different kinds of commits look differently on /graph (RFC)
> 
> This is RFC for two reasons:
> 
> I'm more or less fine with how things look visually (screenshots are in a
> follow-up email), but there's still room for improvement. Feel free to
> criticise or point me to good-looking graphs of this kind for inspiration.

I have no preference, and this patch is floating more than 2 weeks, so let's
make it happen to get a feedback. Can you send V2?

> The second reason is a bit more interesting: currently this patch simply adds
> more items to "vertex" tuple in jsdata.
> 
> I'd like to add to jsdata something that would determine how a graph node
> should look, but the problem is that there are already "node" and "vertex" keys
> in those dicts. This patch has one solution to this problem, but "vertex" is
> actually a tuple of (column, color), and so probably could be split into those,
> freeing up "vertex" for this use case. Or we could have "graphnode" and not
> touch "vertex" at all, but then it might be confused with "node", I don't know.

I slightly prefer a set of named attributes e.g. "obsolete": true, but that
wouldn't be important.


More information about the Mercurial-devel mailing list