D1581: rust: implementation of `hg`

yuja (Yuya Nishihara) phabricator at mercurial-scm.org
Fri Jan 5 07:38:48 UTC 2018


yuja requested changes to this revision.
yuja added a comment.
This revision now requires changes to proceed.


  Suppose this is a kind of contrib code, I think it's good enough to accept.
  Can you drop Cargo.lock file?

INLINE COMMENTS

> Cargo.lock:1
> +[[package]]
> +name = "aho-corasick"

Perhaps Cargo.lock should be excluded from the commit.

> build.rs:88
> +
> +static REQUIRED_CONFIG_FLAGS: [&'static str; 2] = ["Py_USING_UNICODE", "WITH_THREAD"];
> +

Nit: `const` ?

> main.rs:62
> +        mercurial_modules: mercurial_modules.to_path_buf(),
> +    }
> +}

Nit: probably we don't have to `clone()` here, just move these values.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D1581

To: indygreg, #hg-reviewers, yuja
Cc: yuja, quark, durin42, dlax, mercurial-devel


More information about the Mercurial-devel mailing list