D1768: cext: obtain reference to index entry type

[indygreg (Gregory Szorc)]

indygreg added inline comments.

INLINE COMMENTS

> yuja wrote in revlog.c:2117
> Can we be sure that this `IndexV1Entry` is identical to `self->entrytype`
> after reloading Python modules?

In theory, there could be a mismatch.

If this module is loaded, its `IndexV1Entry` will refer to whatever `mercurial.pure.parsers.IndexV1Entry` is. If `mercurial.pure.parsers` is then reloaded and its `IndexV1Entry` changes and a revlog index type is created, its `IndexV1Entry` will be the new one from the reloaded `mercurial.pure.parsers`.

Since I plan to replace the Python-implemented type with a C backed type, I'm inclined to not care about this.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D1768

To: indygreg, #hg-reviewers, yuja
Cc: yuja, mercurial-devel