[PATCH] hgweb: make different kinds of commits look differently on /graph (RFC)

Anton Shestakov av6 at dwimlabs.net
Tue Jan 9 06:52:31 EST 2018


On Sun, 7 Jan 2018 17:55:49 +0800
Anton Shestakov <av6 at dwimlabs.net> wrote:

> On Fri, 5 Jan 2018 15:47:23 +0900
> Yuya Nishihara <yuya at tcha.org> wrote:
> 
> > On Tue, 19 Dec 2017 21:52:15 +0800, Anton Shestakov wrote:  
> > > # HG changeset patch
> > > # User Anton Shestakov <av6 at dwimlabs.net>
> > > # Date 1513687285 -28800
> > > #      Tue Dec 19 20:41:25 2017 +0800
> > > # Node ID c7259f4340b50c8b1863ac9a1379ab8412b27b87
> > > # Parent  e28dedf4ff4368820bbb085c668c3e6ea2088842
> > > hgweb: make different kinds of commits look differently on /graph (RFC)
> > > 
> > > This is RFC for two reasons:
> > > 
> > > I'm more or less fine with how things look visually (screenshots are in a
> > > follow-up email), but there's still room for improvement. Feel free to
> > > criticise or point me to good-looking graphs of this kind for inspiration.    
> > 
> > I have no preference, and this patch is floating more than 2 weeks, so let's
> > make it happen to get a feedback. Can you send V2?  
> 
> I can send a V2, but I'd like to take a stab at making graph use SVG
> first. Let's see if I can do it before the freeze, in the next couple of
> days, and if not, then I'll resend this patch. As it is now, this patch
> would only be half useful for SVG, because SVG would render graph nodes
> in a different way.

Turns out making SVG graph look the same way across browsers is
difficult. For example, Chromium has about 0.5px vertical offset
compared to Firefox, which makes nodes look blurred (because of
anti-aliasing). I'll try and figure out if there's a way to make it
behave, but for now I've sent a V2 of this patch.


More information about the Mercurial-devel mailing list