D1827: scmutil: add warnmessage argument to unhidehashlikerevs function

yuja (Yuya Nishihara) phabricator at mercurial-scm.org
Wed Jan 10 07:52:44 EST 2018


yuja requested changes to this revision.
yuja added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> scmutil.py:1350
> +            warnmessage += " %s\n"
> +            repo.ui.warn(_(warnmessage) % revstr)
>  

`_()` must wrap a string literal.

FWIW, `hiddentype == 'warn'` might not be that useful. See the
comment on the next patch.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D1827

To: pulkit, #hg-reviewers, yuja
Cc: yuja, mercurial-devel


More information about the Mercurial-devel mailing list