D1813: bookmarks: add bookmarks to hidden revs if directaccess config is set

[yuja (Yuya Nishihara)]

yuja requested changes to this revision.
yuja added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> bookmarks.py:856
>          if rev:
> +            warnm = "adding bookmarks to a hidden changeset"
> +            repo = scmutil.unhidehashlikerevs(repo, [rev], 'warn', warnm)

`_("adding ... changeset")`

> bookmarks.py:857
> +            warnm = "adding bookmarks to a hidden changeset"
> +            repo = scmutil.unhidehashlikerevs(repo, [rev], 'warn', warnm)
>              tgt = scmutil.revsingle(repo, rev).node()

Accessing hidden revisions here doesn't mean they will be bookmarked.

Perhaps we should instead warn if `tgt` is a hidden (or obsolete?) revision.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D1813

To: pulkit, #hg-reviewers, yuja
Cc: yuja, mercurial-devel