D1773: revlog: use named attributes on revlog index entries

durin42 (Augie Fackler) phabricator at mercurial-scm.org
Wed Jan 10 17:53:32 EST 2018


durin42 added a comment.


  In https://phab.mercurial-scm.org/D1773#30628, @yuja wrote:
  
  > > However, it is quite large and I suspect it will take a bit more effort to finish it.
  >
  > Isn't that something like `dirstateTupleType`? If we had a native type, we wouldn't
  >  need https://phab.mercurial-scm.org/D1767, https://phab.mercurial-scm.org/D1768, and probably https://phab.mercurial-scm.org/D1769. If it can get rid of refcounting business,
  >  reviewing this series will be much fun.
  
  
  I don't feel strongly about the approach. My bias is to land this whole series as-is. The "lazy struct" should be fairly easily done as a followup.
  
  The refcounting of the type looks okay to me.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D1773

To: indygreg, #hg-reviewers
Cc: durin42, yuja, mercurial-devel


More information about the Mercurial-devel mailing list