D1813: bookmarks: add bookmarks to hidden revs if directaccess config is set

[yuja (Yuya Nishihara)]

yuja requested changes to this revision.
yuja added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> bookmarks.py:859
> +            if ctx.hidden():
> +                repo.ui.warn(_("accessing hidden changeset %s\n") % ctx)
> +            tgt = ctx.node()

Perhaps we can say "bookmarking" or "reviving" instead of "accessing"? I don't know which is better, though.

Another minor problem I found is this warning will be repeated if
you pass more than one bookmark names.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D1813

To: pulkit, #hg-reviewers, yuja
Cc: yuja, mercurial-devel