D1581: rust: implementation of `hg`
kevincox (Kevin Cox)
phabricator at mercurial-scm.org
Thu Jan 11 08:09:35 EST 2018
kevincox added inline comments.
INLINE COMMENTS
> yuja wrote in main.rs:133
> That's more correct on Unix, but wouldn't work on Windows since
> native string is UTF-16 variant (Rust) or ANSI (Python 2.7).
Oops, for some reason I thought this was in a unix block. `as_bytes()` isn't actually available otherise. I think that this is fine then. non-UTF-8 paths shouldn't be a major issue..
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D1581
To: indygreg, #hg-reviewers, yuja, durin42
Cc: kevincox, cramertj, yuja, quark, durin42, dlax, mercurial-devel
More information about the Mercurial-devel
mailing list