D1847: rust: add TODO about lifetime of program_name variable
indygreg (Gregory Szorc)
phabricator at mercurial-scm.org
Thu Jan 11 08:40:26 EST 2018
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG74bec9e74831: rust: add TODO about lifetime of program_name variable (authored by indygreg, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D1847?vs=4791&id=4797
REVISION DETAIL
https://phab.mercurial-scm.org/D1847
AFFECTED FILES
rust/hgcli/src/main.rs
CHANGE DETAILS
diff --git a/rust/hgcli/src/main.rs b/rust/hgcli/src/main.rs
--- a/rust/hgcli/src/main.rs
+++ b/rust/hgcli/src/main.rs
@@ -125,6 +125,9 @@
// Set program name. The backing memory needs to live for the duration of the
// interpreter.
//
+ // TODO consider storing this in a static or associating with lifetime of
+ // the Python interpreter.
+ //
// Yes, we use the path to the Python interpreter not argv[0] here. The
// reason is because Python uses the given path to find the location of
// Python files. Apparently we could define our own ``Py_GetPath()``
To: indygreg, #hg-reviewers, yuja
Cc: mercurial-devel
More information about the Mercurial-devel
mailing list