D1694: debugcommands: replace opts.get('foo') by opts['foo']

yuja (Yuya Nishihara) phabricator at mercurial-scm.org
Fri Jan 12 07:17:51 EST 2018


yuja added a comment.


  In https://phab.mercurial-scm.org/D1694#31044, @durin42 wrote:
  
  > I think it's probably okay for debug commands, those are pretty rare to use as a function aren't they?
  
  
  Yeah, it's okay, but why do we apply a different rule to debug commands?
  
  If we take this, I'd rather replace `.get()` by `[]` everywhere to blame third-party
  tools which don't pass all options.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D1694

To: martinvonz, #hg-reviewers
Cc: durin42, yuja, mercurial-devel


More information about the Mercurial-devel mailing list