D1756: remotenames: introduce class to encapsulate remotenames info in an extension

pulkit (Pulkit Goyal) phabricator at mercurial-scm.org
Sat Jan 13 08:00:43 EST 2018


pulkit added a comment.


  In https://phab.mercurial-scm.org/D1756#31162, @durin42 wrote:
  
  > In https://phab.mercurial-scm.org/D1756#29970, @pulkit wrote:
  >
  > > As per previous discussions, the storage part can only go to core directly (https://phab.mercurial-scm.org/D1358#22905). I am not sure about how out of core extension and in-core extension will interact. Also shall I change this extension name to prevent conflict with the out of core one?
  >
  >
  > My 2ยข: don't worry about the interactions. The existing remotenames is not published on pypi, so it's very unlikely people have it installed and active as just `remotenames=` in their `extensions` block.
  >
  > No idea if others agree though.
  
  
  In that case, I am happy to get this patches reviewed as they are.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D1756

To: pulkit, #hg-reviewers
Cc: durin42, mercurial-devel


More information about the Mercurial-devel mailing list