D1802: Add a template item for linking to a differential review.

indygreg (Gregory Szorc) phabricator at mercurial-scm.org
Sun Jan 14 14:31:46 EST 2018


indygreg requested changes to this revision.
indygreg added a comment.
This revision now requires changes to proceed.


  Please also remove the double newlines and fix the commit message to abide by our message standards.
  
  From the `tests`/ directory, run `./run-tests.py -j8 test-check-*` to run the static analysis checks.

INLINE COMMENTS

> phabricator.py:871-872
> +
> +def extsetup(ui):
> +    templatekw.keywords['phabreview'] = template_review
> +

`registrar.templatekeyword()` returns a function that can be used as a decorator. This is the preferred mechanism to define templates in extensions. See `hgext/transplant.py` for a simple example.

Please switch to that API.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D1802

To: tom.prince, #hg-reviewers, indygreg
Cc: indygreg, pulkit, mercurial-devel


More information about the Mercurial-devel mailing list