[PATCH] bookmarks: calculate visibility exceptions only once

Yuya Nishihara yuya at tcha.org
Mon Jan 15 07:49:56 EST 2018


On Mon, 15 Jan 2018 00:39:37 +0530, Pulkit Goyal wrote:
> # HG changeset patch
> # User Pulkit Goyal <7895pulkit at gmail.com>
> # Date 1515955571 -19800
> #      Mon Jan 15 00:16:11 2018 +0530
> # Node ID a1551e6da839be8d51dc2371520de836ba0f0dba
> # Parent  390f860228ba909499093e0e8861c908fe15a2d0
> bookmarks: calculate visibility exceptions only once

Queued, thanks.

> +    # unhide revs if any
> +    if rev:
> +        repo = scmutil.unhidehashlikerevs(repo, [rev], 'nowarn')
> +
>      for mark in names:
>          mark = checkformat(repo, mark)
>          if newact is None:
> @@ -840,17 +845,16 @@
>              return
>          tgt = cur
>          if rev:
> -            repo = scmutil.unhidehashlikerevs(repo, [rev], 'nowarn')
>              ctx = scmutil.revsingle(repo, rev)

Maybe revsingle() can also be moved out of the loop?


More information about the Mercurial-devel mailing list