D1864: repair: drop unnecessary phase cache invalidation
martinvonz (Martin von Zweigbergk)
phabricator at mercurial-scm.org
Tue Jan 16 20:15:49 UTC 2018
martinvonz created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
After stripping the revlogs, we have been invalidating the phase cache
since https://phab.mercurial-scm.org/rHGbf7b8157c483c3bdb14107099b6db08e94981181. Later, in https://phab.mercurial-scm.org/rHG8e3021fd1a44e48a4720bb6fa4538fba399ad213, I added a call to
phasecache.filterunknown(). I apparently didn't realize it then, but I
now think that that call made the existing phasecache.invalidate()
call unnecessary, so this patch drops it. Both the test added in
https://phab.mercurial-scm.org/rHGbf7b8157c483c3bdb14107099b6db08e94981181 and the entire evolve extension test suite indeed still
pass.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D1864
AFFECTED FILES
mercurial/repair.py
CHANGE DETAILS
diff --git a/mercurial/repair.py b/mercurial/repair.py
--- a/mercurial/repair.py
+++ b/mercurial/repair.py
@@ -222,8 +222,6 @@
if not repo.ui.verbose:
repo.ui.popbuffer()
f.close()
- repo._phasecache.invalidate()
-
with repo.transaction('repair') as tr:
bmchanges = [(m, repo[newbmtarget].node()) for m in updatebm]
To: martinvonz, #hg-reviewers
Cc: mercurial-devel
More information about the Mercurial-devel
mailing list