D1568: lfs: using workers in lfs prefetch

wlis (Wojciech Lis) phabricator at mercurial-scm.org
Tue Jan 16 19:35:19 EST 2018


wlis added a comment.


  I finally got around to testing this properly and I can reproduce the issue. I looked into the code a bit and it is possible that we create keepalive connections before forking and we are illegally multiplexing same connection.
  The quick fix on our side is to not use workers on upload action, and it fixes the issue right away. Proper fix would be to fix the https handler, but it doesn't look like an easy one. I don't think I'll get to that any time soon.
  
  I'll try to submit a patch to only use workers for download to mitigate the issue.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D1568

To: wlis, #hg-reviewers, quark, mharbison72
Cc: mharbison72, quark, mercurial-devel


More information about the Mercurial-devel mailing list