D1855: explicitly kill server processes

[martinvonz (Martin von Zweigbergk)]

martinvonz added a comment.


  In https://phab.mercurial-scm.org/D1855#31684, @martinvonz wrote:
  
  > In https://phab.mercurial-scm.org/D1855#31400, @yuja wrote:
  >
  > > Just for the record, explicit killdaemon isn't needed unless you want
  > >  to do something (e.g. checking server logs) after that. Daemons are
  > >  kill by the test runner.
  >
  >
  > So what was the reason for this patch?
  
  
  I found https://phab.mercurial-scm.org/rHGbc7377160fa732f4c22682bc98c09b76490ca137 that adds this line and a comment saying "Explicitly kill daemons to let the test exit on Windows". Unfortunately, it doesn't explain any more than that. Is Joerg also running on Windows and maybe had the same problem (that the test doesn't exit, whatever that means)?

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D1855

To: joerg.sonnenberger, #hg-reviewers, indygreg
Cc: martinvonz, yuja, mercurial-devel