D1880: blackbox: if --debug is used, also trace ui.debug() calls

[yuja (Yuya Nishihara)]

yuja requested changes to this revision.
yuja added a comment.
This revision now requires changes to proceed.


  I'm 0 on this, but I have no reason against it.

INLINE COMMENTS

> blackbox.py:136
> +            if self.debugflag:
> +                self.log('debug', *msg, **opts)
> +

These arguments can't be passed directly to `.log()`.
`.log()` takes a format string and its parameters, whereas `.debug()`
takes a list of arbitrary strings to print.

Perhaps `**opts` should be dropped.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D1880

To: joerg.sonnenberger, #hg-reviewers, yuja
Cc: yuja, mercurial-devel