D1884: strip: use %d for known-int string interpolation
yuja (Yuya Nishihara)
phabricator at mercurial-scm.org
Thu Jan 18 09:07:08 EST 2018
yuja added inline comments.
INLINE COMMENTS
> durin42 wrote in strip.py:218
> I'm unclear: are you asking to remove the b-prefix? Adding it was intentional, since eventually we're going to need to rewrite everything so we can ditch the module loader hack.
No. I mean it should use revset.formatspec. i.e. `revs(expr, arg)` instead of `revs(expr % arg)`.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D1884
To: durin42, #hg-reviewers, pulkit
Cc: yuja, pulkit, mercurial-devel
More information about the Mercurial-devel
mailing list