D1755: logexchange: introduce helper function to get remote path name

durin42 (Augie Fackler) phabricator at mercurial-scm.org
Thu Jan 18 15:02:31 EST 2018


durin42 added inline comments.

INLINE COMMENTS

> logexchange.py:102
> +        local = remote.local()
> +    except AttributeError:
> +        pass

what's the deal with this attributeerror business? merits a comment at least

> logexchange.py:113
> +            rpath = remote._url
> +        except AttributeError:
> +            rpath = remote.url

is the attribute name here really still inconsistent in hg?

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D1755

To: pulkit, #hg-reviewers, durin42
Cc: durin42, mercurial-devel


More information about the Mercurial-devel mailing list