D1074: branch: add a --rev flag to change branch name of given revisions

pulkit (Pulkit Goyal) phabricator at mercurial-scm.org
Fri Jan 19 02:57:08 EST 2018


pulkit removed subscribers: durin42, krbullock, yuja, indygreg.
pulkit marked 5 inline comments as done.
pulkit added inline comments.

INLINE COMMENTS

> martinvonz wrote in commands.py:1051-1056
> Does this need to be modified to work with --rev? I've never used `hg branch`, but it sounds like `hg branch foo` (without --force) is supposed to fail if `foo` is already taken unless one of the working directory parents already has that name. Should we do the corresponding check for --rev? If not, it seems like we should at least *not* do the check (in its current form) when --rev is given. If I'm doing `hg branch --rev deadbeef foo`, it doesn't seem relevant what the branch names in my working directory parents are. Would be good to add a test case or two for this too.

This is a very basic and experimental implementation, hence I have changed the logic to not accept a new name if any such name already exists. Test cases are also added.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D1074

To: pulkit, #hg-reviewers, dlax, ryanmce
Cc: martinvonz, lothiraldan, ryanmce, dlax, mercurial-devel


More information about the Mercurial-devel mailing list