[PATCH 14 of 14 V3] streamclone: also stream caches to the client

Augie Fackler raf at durin42.com
Fri Jan 19 21:08:46 EST 2018


On Sat, Jan 20, 2018 at 12:47:19AM +0100, Boris Feld wrote:
> # HG changeset patch
> # User Boris Feld <boris.feld at octobus.net>
> # Date 1516233012 -3600
> #      Thu Jan 18 00:50:12 2018 +0100
> # Node ID d44178c3fd9576e6ca6ab6e92b9823f117141079
> # Parent  9c2889f5050bea9d33be5f501eaf1ecf2d9617d3
> # EXP-Topic b2-stream
> # Available At https://bitbucket.org/octobus/mercurial-devel/
> #              hg pull https://bitbucket.org/octobus/mercurial-devel/ -r d44178c3fd95
> streamclone: also stream caches to the client

queued with lots of frustration - please budget time better in the
future so that big/important series aren't showing up the day of the
freeze.

> diff --git a/mercurial/streamclone.py b/mercurial/streamclone.py
> --- a/mercurial/streamclone.py
> +++ b/mercurial/streamclone.py

[...]

> @@ -507,10 +527,11 @@ def generatev2(repo):
>      """Emit content for version 2 of a streaming clone.
>
>      the data stream consists the following entries:
> -    1) A varint containing the length of the filename
> -    2) A varint containing the length of file data
> -    3) N bytes containing the filename (the internal, store-agnostic form)
> -    4) N bytes containing the file data
> +    1) A char representing the file destination (eg: store or cache)

Please send a followup before 4.5 goes final that documents *here*
what these characters are. Don't make people read the code to figure
out the specifics of the format.

> +    2) A varint containing the length of the filename
> +    3) A varint containing the length of file data
> +    4) N bytes containing the filename (the internal, store-agnostic form)
> +    5) N bytes containing the file data


More information about the Mercurial-devel mailing list