[PATCH] keyword: replace map() with list comprehension
Yuya Nishihara
yuya at tcha.org
Sat Jan 20 07:29:37 EST 2018
On Sat, 20 Jan 2018 12:00:00 +0100, Christian Ebert wrote:
> # HG changeset patch
> # User Christian Ebert <blacktrash at gmx.net>
> # Date 1516442383 -3600
> # Sat Jan 20 10:59:43 2018 +0100
> # Node ID f1d6d72008e373c24b8057bebe999544f7a45711
> # Parent 2384523cee4dcc83f67b73bf1862c68ddf1afc49
> keyword: replace map() with list comprehension
for what?
Anyway, we're in code freeze. Please resend on February 1st.
> diff --git a/hgext/keyword.py b/hgext/keyword.py
> --- a/hgext/keyword.py
> +++ b/hgext/keyword.py
> @@ -238,7 +238,7 @@ class kwtemplater(object):
> @util.propertycache
> def escape(self):
> '''Returns bar-separated and escaped keywords.'''
> - return '|'.join(map(re.escape, self.templates.keys()))
> + return '|'.join([re.escape(k) for k in self.templates.keys()])
Nit: [] isn't needed.
More information about the Mercurial-devel
mailing list