D1932: bundle2: increase payload part chunk size to 32kb

[indygreg (Gregory Szorc)]

indygreg added a comment.


  In https://phab.mercurial-scm.org/D1932#32544, @lothiraldan wrote:
  
  > The improvement seems nice for the stream but it might have unintended consequences on other network operations. Would it be possible to introduce a config knob to restore the old value or tune it later?
  
  
  I agree a commit knob would be useful. Could be done as a follow-up easily enough.
  
  As to whether this will have an impact on other network operations, I'm skeptical. I'm pretty sure we already use 32kb chunks in other places. And, the SSH protocol today may not do any buffering, meaning that each chunk from the iterator gets turned into a socket.send(). That may be creating a ton of TCP overhead...

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D1932

To: indygreg, #hg-reviewers
Cc: lothiraldan, mercurial-devel