[PATCH 15 of 25 RFC] phase: enforce internal phase support

Boris FELD lothiraldan at gmail.com
Mon Jul 2 16:15:36 EDT 2018



On 02/07/2018 19:00, Augie Fackler wrote:
>
>> On Jul 2, 2018, at 11:49, Boris FELD <lothiraldan at gmail.com> wrote:
>>
>> Hello, coming back from vacation.
>>
>> I've seen part of the series queued, is there a reason for the two last commits to not being queued yet?
> I just didn't have time to review. I'd appreciate it if you could rebase and update the remaining patches that are refactors (just to be on the safe side), and get more of the refactoring prep-work changes (if there are any) on phabricator so I can burn through them in a single batch once I have some time.
>
> (This week is a holiday in the US, so reviewer bandwidth may be somewhat limited - I'll try to get to these tomorrow, but I can't make promises.)

The phabricator stack has been updated, the two remaining patches were 
the only one remaining ones of the refactoring series.

>
>> Please drop the current RFC series, we will send the new series with a higher number for the internal phase after the refactoring series has fully landed.
>>
>> On 25/06/2018 18:44, Augie Fackler wrote:
>>>> On Jun 7, 2018, at 10:11, Boris Feld <boris.feld at octobus.net> wrote:
>>>>
>>>> # HG changeset patch
>>>> # User Boris Feld <boris.feld at octobus.net>
>>>> # Date 1527610399 -7200
>>>> #      Tue May 29 18:13:19 2018 +0200
>>>> # Node ID ef202521c3c3389198ff917e11dcb7847de3658d
>>>> # Parent  d6ac390e2ebdf51f095168fe314dd956db09e2b9
>>>> # EXP-Topic internal-phase
>>>> # Available At https://bitbucket.org/octobus/mercurial-devel/
>>>> #              hg pull https://bitbucket.org/octobus/mercurial-devel/ -r ef202521c3c3
>>>> phase: enforce internal phase support
>>> I'm going to drop this whole series for now, but many thanks for sending it. My comfort level is to make sure the internal phase gets a much higher number, so we've got room in the future for new phases (an "archived" phase has already been discussed, for example).
>>>
>>> I've queued a few things from phabricator that make sense, and we'll come back to this series when you're ready. Sound good?
>>>
>>> Thanks!
>>>
>>> _______________________________________________
>>> Mercurial-devel mailing list
>>> Mercurial-devel at mercurial-scm.org
>>> https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel



More information about the Mercurial-devel mailing list