D3919: grep: restore pre-9ef10437bb88 behavior, enable wdir search by tweakdefaults

durin42 (Augie Fackler) phabricator at mercurial-scm.org
Wed Jul 11 14:21:40 EDT 2018


durin42 added a comment.


  I think it would make sense to defer the behavior change until we test some more. That said, I do want us to plan to make an intentionally breaking change with the out of the box grep experience *without* `tweakdefaults` enabled. My reasoning is more or less this: approximately nobody uses `hg grep` today[0] because its behavior doesn't match what users expect out of the box. I'm willing to call the current behavior a *bug*, and prominently announce that with 4.8 we expect to change the default behavior of `hg grep` to match user expectations. That's in line with the decision outlined in [1] which is old enough that mpm was part of the decision. I strongly suspect hglib will be the only meaningful breakage, and we can patch hglib to pass the -r 0:tip flag that'll give consistent behavior across all hg versions.
  
  How do we feel about that?
  
  0: Anecdata:  it's been run 25 times at work in the last 30 days over our entire userbase, which includes a number of extremely advanced users, and has been renamed to `histgrep` at Facebook for at least 4 years.
  1: https://www.mercurial-scm.org/wiki/GrepPlan

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D3919

To: yuja, #hg-reviewers, sangeet259, pulkit
Cc: durin42, mercurial-devel


More information about the Mercurial-devel mailing list