[PATCH 1 of 2] config: introduce load order tracking

Yuya Nishihara yuya at tcha.org
Fri Jul 13 09:01:47 EDT 2018


On Fri, 13 Jul 2018 10:30:33 +0200, Boris FELD wrote:
> On 11/07/2018 13:32, David Demelier wrote:
> > On Wed, 2018-07-11 at 00:01 +0900, Yuya Nishihara wrote:
> >> If the problem to be addressed by this hack is important, and if the
> >> hack is
> >> really simple, sure I would say go for it. But I, as an old Mercurial
> >> user,
> >> see the bulk renaming of the config keys is minor improvement.
> > I think it's important, consistency in a software shows a strong core
> > guideline applied and strict reviewing. The current hgrc manual shows
> > three different styles along with unreadable names like
> > backgroundclosethreadcount.
> 
> We agree with David here that consistency helps the user experience.

I know. I'm just saying it isn't an immediate problem enough to add a
one-off hack to the config system.

> Even for more experienced contributors, configuration inconsistency
> leads to waste time at multiple occurrences on mistakes. This happens on
> a regular basis at octobus or at places we provide support to.

For that purpose, I think it's better to add a linter (e.g. hg config --check)
to detect unknown (but similar to registered) names. Inserting dashes to every
config name is merely a partial solution for ambiguous naming. There's always
inconsistency such as "X-count" vs "Xs" for the number of X.


More information about the Mercurial-devel mailing list