D3871: rebase: improve output of --confirm option

durin42 (Augie Fackler) phabricator at mercurial-scm.org
Fri Jul 13 10:02:47 EDT 2018


durin42 added a comment.


  This doesn't apply cleanly, could you rebase it?

INLINE COMMENTS

> rebase.py:975
>              with util.acceptintervention(dsguard):
> -                rbsrt._performrebase(tr)
> +                rbsrt._performrebase(tr, supprbinfo=supprbinfo)
>                  if not leaveunfinished:

I feel like the functions that accept supprbinfo should grow a docstring or comment that explains what supprbinfo does.

(I sort of figured it out, but it took a while.)

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D3871

To: khanchi97, #hg-reviewers
Cc: durin42, mercurial-devel


More information about the Mercurial-devel mailing list