D3957: patchbomb: python 3 really wants those email addresses in unicode

durin42 (Augie Fackler) phabricator at mercurial-scm.org
Mon Jul 16 23:16:31 UTC 2018


durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.

REVISION SUMMARY
  At this point, test-patchbomb-tls.t almost passes on Python 3, but I'm
  not really sure what the issue is: we just get a `abort: Connection
  unexpectedly closed` that doesn't make sense to me.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D3957

AFFECTED FILES
  hgext/patchbomb.py

CHANGE DETAILS

diff --git a/hgext/patchbomb.py b/hgext/patchbomb.py
--- a/hgext/patchbomb.py
+++ b/hgext/patchbomb.py
@@ -821,6 +821,8 @@
             generator = emailgen.Generator(_filestrtobytesfacade(fp),
                                            mangle_from_=False)
             generator.flatten(m, 0)
-            sendmail(sender_addr, to + bcc + cc, fp.getvalue())
+            alldests = to + bcc + cc
+            alldests = [pycompat.strurl(d) for d in alldests]
+            sendmail(sender_addr, alldests, fp.getvalue())
 
     progress.complete()



To: durin42, #hg-reviewers
Cc: mercurial-devel


More information about the Mercurial-devel mailing list