D3962: worker: ability to disable thread unsafe tasks

yuja (Yuya Nishihara) phabricator at mercurial-scm.org
Thu Jul 19 08:15:12 EDT 2018


yuja added a comment.


  >   if pycompat.isposix or pycompat.iswindows:
  >       _STARTUP_COST = 0.01
  > 
  > +    # The Windows worker is thread based. If tasks are CPU bound, threads
  >  +    # in the presence of the GIL result in excessive context switching and
  >  +    # this overhead can slow down execution.
  >  +    _DISALLOW_THREAD_UNSAFE = True
  
  Fixed this as `_DISALLOW_THREAD_UNSAFE = pycompat.iswindows`, and queued.
  Thanks.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D3962

To: indygreg, #hg-reviewers, lothiraldan
Cc: yuja, mercurial-devel


More information about the Mercurial-devel mailing list