D3967: dispatch: making all hg abortions be output with a specific label

[martinvonz (Martin von Zweigbergk)]

martinvonz accepted this revision.
martinvonz added a comment.
This revision is now accepted and ready to land.


  Looks good! I won't queue it now because it's freeze and it feels controversial enough that I shouldn't queue it anyway. I've actually wanted a ui.error() for some time and it's just the fact that we still don't have have it that makes me wonder if it's controversial.

INLINE COMMENTS

> scmutil.py:172-173
>              reason = _('lock held by %r') % inst.locker
> -        ui.warn(_("abort: %s: %s\n")
> -                % (inst.desc or stringutil.forcebytestr(inst.filename), reason))
> +        ui.error(_("abort: %s: %s\n") % (
> +            inst.desc or stringutil.forcebytestr(inst.filename), reason))
>          if not inst.locker:

nit: revert formatting change

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D3967

To: rdamazio, #hg-reviewers, martinvonz
Cc: martinvonz, mercurial-devel