D3557: extensions: new closehead module for closing arbitrary heads

pulkit (Pulkit Goyal) phabricator at mercurial-scm.org
Mon Jul 23 14:46:58 EDT 2018


pulkit added a comment.


  Sorry for getting late to review this. Found a minor nit and also looks like you missed adding tests for bookmark movement and phase preservation.

INLINE COMMENTS

> closehead.py:55
> +
> +    if not revs:
> +        raise error.Abort(_('no revisions specified'))

revs can be passed as opts['rev'] too now.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D3557

To: joerg.sonnenberger, #hg-reviewers
Cc: indygreg, pulkit, mercurial-devel


More information about the Mercurial-devel mailing list