D3980: contrib/phabricator: Convert description into local

martinvonz (Martin von Zweigbergk) phabricator at mercurial-scm.org
Wed Jul 25 15:07:12 EDT 2018


martinvonz added a comment.


  In https://phab.mercurial-scm.org/D3980#61930, @yuja wrote:
  
  > >   getdescfromdrev is also used in readpatch which call encoding.unitolocal after.
  > >   So it looks like it is designed to be converted after the call.
  >
  > Can you fix them all? A general guideline for Mercurial codebase is converting
  >  unicodes to byte strings as early as possible.
  
  
  Maybe it should even be done where callconduit() returns (i.e. line 216)?

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D3980

To: ced, #hg-reviewers
Cc: martinvonz, yuja, mercurial-devel


More information about the Mercurial-devel mailing list