D3716: ui: add an uninterruptable context manager that can block SIGINT
mharbison72 (Matt Harbison)
phabricator at mercurial-scm.org
Sat Jul 28 15:05:07 EDT 2018
mharbison72 added a comment.
In https://phab.mercurial-scm.org/D3716#61963, @durin42 wrote:
> > Do we need a different strategy for Windows, or just eat the error? (See the unsupported signal message)
> >
> > https://buildbot.mercurial-scm.org/builders/Win7%20x86_64%20hg%20tests/builds/808/steps/run-tests.py%20%28python%202.7.13%29/logs/stdio
>
> I'm not sure. We could probably just not support this on windows for now, or at least disable the test on Windows?
I’m ok with disabling the test as long as it doesn’t explode on Windows without turning the experimental knobs. It sounded like future would would depend on this, and I wasn’t sure if that landed yet.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D3716
To: durin42, #hg-reviewers, indygreg
Cc: mharbison72, spectral, indygreg, yuja, martinvonz, mercurial-devel
More information about the Mercurial-devel
mailing list