D3671: advanceboundary: add dryrun parameter

pulkit (Pulkit Goyal) phabricator at mercurial-scm.org
Fri Jun 1 05:25:15 EDT 2018


pulkit added a comment.


  Nice work! Returning a set of changesets whose phase is changed or can be changed is a better API than returning a rejected list and a list of sets.

INLINE COMMENTS

> phases.py:358
>  
>          Nodes with a phase lower than 'targetphase' are not affected.
>          """

Add docs about dryrun and return value here too.

> phases.py:382
> +            if dryrun:
> +                changes.update(affected)
> +                continue

We should populate the changes set and return that even if we are performing actions.

> phases.py:496
> +    If dryrun is true then it will not perform any action and only returns
> +    revisions whose phase could be changed.
> +    """

The return value should be set of revisions who phase is changed or can be changed irrespective of whether dry-run is passed or not.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D3671

To: khanchi97, #hg-reviewers, pulkit
Cc: pulkit, mercurial-devel


More information about the Mercurial-devel mailing list