D3669: cmdutil: have statefile names in STATES instead of functions

[martinvonz (Martin von Zweigbergk)]

martinvonz added inline comments.

INLINE COMMENTS

> pulkit wrote in cmdutil.py:3210
> > How about instead making unfinishedstates more generic by supporting a predicate there
> >  instead of the file? We could still allow files as well for BC for a little while.
> 
> @martinvonz : because of above util.unlink() we have to keep the filenames in unfinishedstates. :(

We don't have to. We could add a `clearstatefn` function in addition to the `statedetectionpredicate`. Perhaps the `if not clearable and ...` stuff could move into the function in that case

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D3669

To: pulkit, #hg-reviewers
Cc: martinvonz, mercurial-devel