[PATCH] outgoing: drop an extraneous URL parse

Matt Harbison mharbison72 at gmail.com
Sat Jun 2 16:33:04 UTC 2018


# HG changeset patch
# User Matt Harbison <matt_harbison at yahoo.com>
# Date 1527910397 14400
#      Fri Jun 01 23:33:17 2018 -0400
# Node ID 22edd5321489205e44f27f5eaf31f105f7f7e10b
# Parent  f715faeaceeec38ff1551fbccdd45c0c0ba3df85
outgoing: drop an extraneous URL parse

This was left over from dfb888aae17a.  'branches' wasn't used, and the only
thing parseurl() would do is slice any branch fragment off 'dest'.  But path.loc
and path.pushloc already have the fragment removed.

diff --git a/mercurial/commands.py b/mercurial/commands.py
--- a/mercurial/commands.py
+++ b/mercurial/commands.py
@@ -3736,7 +3736,6 @@ def outgoing(ui, repo, dest=None, **opts
 
     if opts.get('bookmarks'):
         dest = path.pushloc or path.loc
-        dest, branches = hg.parseurl(dest, opts.get('branch'))
         other = hg.peer(repo, opts, dest)
         if 'bookmarks' not in other.listkeys('namespaces'):
             ui.warn(_("remote doesn't support bookmarks\n"))


More information about the Mercurial-devel mailing list